-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add header to Codex API requests for capturing product analytics data #53
Conversation
The Python package version we're currently including in headers is from the |
The PRD mentions supporting the ability to opt out of telemetry. Seems like that's not addressed here, so wondering if you had a plan for that? |
I'm not including the
Including the |
The telemetry won't be sent directly from this client library code - it'll be sent from the Codex backend (I'm still in the middle of making that change). So we should be alright on that requirement! |
@axl1313 branch is updated and re-tested according to your feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple non-blocking comments, but looks good!
@@ -90,6 +90,13 @@ Automated releases are handled by the [release workflow][release-workflow] which | |||
[hatch-version]: https://hatch.pypa.io/latest/version/#updating | |||
[changelog]: CHANGELOG.md | |||
|
|||
|
|||
### How to build and install the package locally |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can also just do pip install -e <local path to repo>
self, *, integration_type: str, package_version: str = package_version, source: str = "cleanlab-codex-python" | ||
): | ||
class IntegrationType(str, Enum): | ||
"""Types of integrations that can use the SDK.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
"""Types of integrations that can use the SDK.""" | |
"""Supported methods for integrating Codex into a RAG system using this library""" |
Key Info
What changed?
AnalyticsMetadata
which is passed in request headers to Codex API, for the purpose of capturing product analytics about usage; mainly, what integration type (tool or backup) the request is associated withutils/project.py
and moved intoproject.py
test_codex_tool
What do you want the reviewer(s) to focus on?
'user-agent': 'Codex/Python 0.1.0-alpha.9'
), which I do plan on passing to Posthog as wellChecklist
CODEX_BASE_URL
); verified that the headers are passed properly