Skip to content

feat: add cypherQuery as a label in the metrics #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: add cypherQuery as a label in the metrics #72

wants to merge 1 commit into from

Conversation

jmbass
Copy link
Collaborator

@jmbass jmbass commented Jun 2, 2022

  • Adds the cypher query as a label of the execution time observation.

feat: add cypherQuery as a label in the metrics
c73aebd 
- Adds the cypher query as a label of the execution time observation.
clems4ever
clems4ever requested changes Jun 17, 2022
View reviewed changes
Copy link
Owner

@clems4ever clems4ever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this you risk to grow a lot the number of metrics in prometheus and blow it up. I would not advise it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clems4ever clems4ever clems4ever requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmbass @clems4ever