Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes arbitrary width property #30

Merged
merged 1 commit into from
Aug 14, 2018
Merged

removes arbitrary width property #30

merged 1 commit into from
Aug 14, 2018

Conversation

gabrielcsapo
Copy link
Contributor

problem here gabrielcsapo/node-git-server#25 (comment)

before after
32589396-22399ef0-c50c-11e7-8ef8-16a7daab401d screen shot 2017-11-08 at 10 00 25 pm

@ar2rsawseen
Copy link
Collaborator

With approval from author, finally we decided to go with our own version of this repo and published it as npm package. Feel free to check it out and send your PRs there.
https://www.npmjs.com/package/countly-docdash

@gabrielcsapo
Copy link
Contributor Author

gabrielcsapo commented May 29, 2018

@ar2rsawseen I think it would have been better to just maintain this repo, but will open my PR against your new package.

@clenemt
Copy link
Owner

clenemt commented May 30, 2018

@ar2rsawseen if you want I can give you access to this repo if you feel like maintaining this instead of creating a new one. Let me know 👍

@ar2rsawseen
Copy link
Collaborator

That's a possibility we considered, yes, but we are interested in the template from company perspective, all internal docs on it, and now want to produce external ones too, etc. And while currently I am only one dedicated to it, it might change and future, and as with every company new employees join and go, and adding/removing each and every one of them would be tiresome for you. But since we already control access on our account for teams, it will be easier for us.

Other way this could work, is, if you are willing to transfer ownership of repo to our account, but then again it would probably mess up npm packages and would need to publish new one either way. That's why we decided to go this way, hope everyone understands :)

@gabrielcsapo
Copy link
Contributor Author

Props to @clenemt +1

@clenemt
Copy link
Owner

clenemt commented May 31, 2018

@ar2rsawseen you are now a collaborator, you should be able to mark this repo as deprecated and redirect to your own in the README. Good luck out there 👍

@ar2rsawseen
Copy link
Collaborator

@clenemt if you can add me on npm too, we can try to manage this repo with same npm package then

@ar2rsawseen ar2rsawseen merged commit 47d7a77 into clenemt:master Aug 14, 2018
@hugolpz
Copy link

hugolpz commented Mar 31, 2021

@clenemt, please see #98. Time for more maintainers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants