chore(clerk-js,types,localizations): Break out subscriptions and plans within User/OrgProfile #5727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8c4c4f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 22 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
aeliox
changed the title
aeliox
changed the title
|
looking good! any chance we can get the page title separator in there? on the "Available plans" page? |
|
Also, the plan tiles have a slight shadow on them. Same shadow as the tables: |
|
@drewwilson @aeliox Is this white space on purpose ? |
|
The bottom part and the border on the footer, seem weird if no features exist. |
panteliselef
previously requested changes
Apr 27, 2025
Comment on lines
+69
to
+74
| <Route path='plans'> | ||
| {/* TODO(@commerce): Should this be lazy loaded ? */} | ||
| <Suspense fallback={''}> | ||
| <PlansPage /> | ||
| </Suspense> | ||
| </Route> |
There was a problem hiding this comment.
- Can we lazy load ?
- Adding this page possibly means that we cannot just remove it later since it become part of a url which is considered public api.
packages/clerk-js/src/ui/components/PricingTable/PricingTableDefault.tsx
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/PricingTable/PricingTableDefault.tsx
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/PricingTable/PricingTableDefault.tsx
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/PricingTable/FreePlanRow.tsx
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/UserProfile/BillingPage.tsx
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/PricingTable/PricingTableDefault.tsx
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/Subscriptions/SubscriptionsList.tsx
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/Subscriptions/SubscriptionsList.tsx
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/UserProfile/BillingPage.tsx
Outdated
Show resolved
Hide resolved
packages/clerk-js/src/ui/components/Subscriptions/SubscriptionDetails.tsx
Outdated
Show resolved
Hide resolved
alexcarpenter
approved these changes
Apr 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
UserProfileandOrgProfilePricingTableSubscriptionDetailssupport for plans without a current subscriptionhttps://linear.app/clerk/issue/COM-597/break-out-subscriptions-from-pricingtable-in-userorg-profile
https://linear.app/clerk/issue/COM-517/update-badging-on-subscription-rows
https://linear.app/clerk/issue/COM-626/subscriptiondetails-needs-a-state-for-no-subscription
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change