fix(clerk-js): Fix tasks navigation with server cache revalidation #6382
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| const { __internal_setActiveInProgress } = useClerk(); | ||
|
|
||
| React.useEffect(() => { | ||
| // Handle the case where a user lands on alternative methods screen, | ||
| // clicks a social button but then navigates back to sign in. | ||
| // SignIn status resets to 'needs_identifier' | ||
| if (signIn.status === 'needs_identifier' || signIn.status === null) { | ||
| if ((signIn.status === 'needs_identifier' || signIn.status === null) && !__internal_setActiveInProgress) { | ||
| void router.navigate('../'); | ||
| } | ||
| }, []); | ||
| }, [__internal_setActiveInProgress]); |
There was a problem hiding this comment.
This is a rough patch for the issue. I think it's much more than that, we should integrate it within our router maybe.
Atm I don't have a lot of understanding on invalidateCacheAction to propose a better solution. Trying to scope it to unblock after-auth release.
Description
When setting a
pendingsession to the client withsetActive, it should callonBeforeSetActiveto revalidate server cache.This is necessary to ensure that server-side components that rely on the session are re-rendered.
However, it was causing an issue where
SignInFactorOnere-renders and triggers a navigation to the root.Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change