Fix #331: sexpr on tagged literal should be fully qualified #332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmmm... Seems to break cljs tests... and also zprint and umschreiben-clj. |
|
The test in umschreiben fails exactly because they depend on the unqualified symbol right now |
|
Kinda feels sort similar in spirit to #305? zprint had some problems with that one too kkinnear/zprint#333 |
|
@borkdude, this isn't PR isn't solving any immediate problem for me, so I've not been inclined to look into it, nor think about it. Do you still think we should do something here? |
|
Eventually yes, since emitting an qualified name can lead to bad behavior. |
|
Ok, tx, have followed up in issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.