CI - Fix the external contributor check #2591
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This was using a GH token that was not passed to external CI, so the contributor check would always fail. This was originally broken in #194.
I just switched it to using the
GITHUB_TOKENsecret, which is passed to CI on external PRs (see https://docs.github.com/en/actions/security-for-github-actions/security-guides/using-secrets-in-github-actions#using-secrets-in-a-workflow).We will also have to update the
GITHUB_TOKENtoken to have permissions to list org members.API and ABI breaking changes
None. CI-only change.
Expected complexity level and risk
1
Testing
None, because I don't want to create a whole new GitHub account and repo just to open a test PR.
I say we merge this and test with one of the many open PRs, e.g. #2416 (where the author has signed the CLA).