Add the primary key type to typescript's TableRuntimeTypeInfo
#2671
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The TableRuntimeTypeInfo that we have in the typescript SDK currently has the name of the primary key (if it exists), and the type of the rows. That is technically enough to figure out the
AlgebraicType
of the primary key with something likerowType.product.elements.find( (element: ProductTypeElement) => {element.name === primaryKey})?.algebraicType
, but it's more convenient to have it generated for us.This adds a field that looks like:
We are still generating
primaryKey
field, so we don't need to release a new TS SDK version and CLI version at the same time, but eventually we can get rid of it.API and ABI breaking changes
This is just adding a field in generated typescript code, which shouldn't break anything.
Expected complexity level and risk
Testing
I've tested the current TS sdk with the newly generated code to ensure it doesn't break, and I'm working on a TS PR that will use the new field. I have enough of the new code working that I have tested the newly generated fields.