Adding Abort to C# Websocket #3352
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
The implementation of a solution to #3044 , this adds an
Abort
function to theWebSocket
, which runs ifDisconnect
is called when theWebSocket
is not connected.API and ABI breaking changes
Not API breaking.
Expected complexity level and risk
1
Testing
Note: Before change (either on Rust of C# server), server would see 4
Debug
log entries about connecting, but not see theInfo
log about the client connection ending like would normally be seen in a disconnect. After change, server shows no log entries at all, because connection is properly aborted.