Fixes an issue where we use table_name_camelcase instead of table_name for useTable in TypeScript
#3354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloutiertyler
commented
Oct 4, 2025
Signed-off-by: Tyler Cloutier <[email protected]>
cloutiertyler
commented
Oct 4, 2025
Signed-off-by: Tyler Cloutier <[email protected]>
cloutiertyler
commented
Oct 4, 2025
cloutiertyler
commented
Oct 4, 2025
Signed-off-by: Tyler Cloutier <[email protected]>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 4, 2025
…e for `useTable` in TypeScript (#3354) # Description of Changes This resolves an issue reported in Discord: https://discordapp.com/channels/1037340874172014652/1398209084699709492/1423784670402842766 > note the name is Counter. in the typescript bindings, my useTable only gives me the option for counter => useTable<DbConnection, Counter>('counter'); > I switched my name in the c# module to [SpacetimeDB.Table(Public = true, Name = "counter")] and it just works. > Capitalization and whatnot strikes again The diff seems large because of the mechanical changes to codegen. You only really need to review code gen'd tables and `index.ts`. All the other files just have a new `__TableHandle` type import. # API and ABI breaking changes Technically API breaking, but it fixes a bug where the old API doesn't work # Expected complexity level and risk 2, relatively straight-foward changes to the TS SDK and TS codegen # Testing - [x] I have tested with a Rust module that has an `UpperCase` table, that that name is passed correctly down to the TypeScript client through the codegen and that it works in `useTable` --------- Signed-off-by: Tyler Cloutier <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
jsdt
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This resolves an issue reported in Discord:
https://discordapp.com/channels/1037340874172014652/1398209084699709492/1423784670402842766
The diff seems large because of the mechanical changes to codegen. You only really need to review code gen'd tables and
index.ts. All the other files just have a new__TableHandletype import.API and ABI breaking changes
Technically API breaking, but it fixes a bug where the old API doesn't work
Expected complexity level and risk
2, relatively straight-foward changes to the TS SDK and TS codegen
Testing
UpperCasetable, that that name is passed correctly down to the TypeScript client through the codegen and that it works inuseTable