Jsdt/ws v2 #4213
Draft
Jsdt/ws v2 #4213
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Incl. mention of future possibility of PK-ful partial updates.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Resolve merge conflicts and fix compilation errors: - Recreate message_handlers_v1.rs and message_handlers_v2.rs (v1/v2 dispatch) - Adapt for Option<ReducerName> change from master - Convert TableName to Box<str> for TableUpdate::new calls - Fix async closure annotations in call_view_add_v2_subscription - Fix BTreeMap key type (TableName doesn't impl Ord)
cloutiertyler
force-pushed
the
jsdt/ws-v2
branch
from
27e5d09 to
9437a55
Compare
Both types wrap Identifier which already implements Ord. Revert the Box<str> workaround in module_subscription_manager.
RowListLen is defined in websocket::common but was not re-exported from websocket::v1. Import it directly from common instead.
Zero-sized rows are well-defined, and we have tests that rely on them working
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
API and ABI breaking changes
Expected complexity level and risk
Testing