Reorganize types generated for typescript clients #4258
+1,007
−371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Cherry-picking #4127 from the
2.0-breaking-changesbranch.Original PR Description
This changes generated types in ts client bindings. We currently generate a few different types of types: reducer args, procedure args, rows, and user defined types. To avoid potential conflicts between these types (for example, if a user defined a type called
FooRow, and also had a tabled namedfoo, we would end up with two types namedFooRow), this puts each set of types in a different file and namespace. We also stopped exporting thexxxRowtypes, because there is always another type generated for those. We now have atypesdirectory, which has anindex.tswith user defined types, along withreducers.tsandprocedures.tsfor the types generated for reducer/procedure parameters.or
This has a couple other changes:
Args, since we may want types for the return values in the future.export type Message = __Infer<typeof MessageRow>;). I couldn't think of a reason for users to want the schema object, so this should save users from needing to do all of theInferboilerplate.This is a breaking change for v2.