Add defcustom for major-mode remapping#64
Conversation
|
Looks good. I noticed |
clojure-ts-mode.el
Outdated
| :safe #'booleanp | ||
| :package-version '(clojure-ts-mode . "0.2.3")) | ||
|
|
||
| (defcustom clojure-ts-auto-redirect t |
There was a problem hiding this comment.
Perhaps clojure-ts-auto-remap or clojure-ts-auto-remap-modes would be slightly better name.
There was a problem hiding this comment.
I've renamed it to clojure-ts-auto-remap, wasn't sure if it should have a -p suffix being a boolean? Feel free to change it further (maybe the commands too, clojure-ts-activate -> clojure-ts-activate-remapping)
|
I've removed the commit which uses defcustom setter to trigger activate/deactivate calls on |
|
Okay, I guess that will do for now. I thought a bit too late that probably those commands shouldn't do anything if |
|
Good to know, I'll update the code to use it. |
Closes #63
Naming of defcustom / commands open to change, if alright I can go ahead and edit the changelog/Readme
Before submitting a PR mark the checkboxes for the items you've done (if you
think a checkbox does not apply, then leave it unchecked):
M-x checkdocand fixed any warnings in the code you've written.Thanks!