Open
Conversation
Made m-lift-fn curried, and added a test that uses m-lift-fn (just a duplicate of a test that uses m-lift)
Member
|
Hi Sgeo, thanks for the suggestion but Clojure and its contrib projects are not able to accept pull requests. You can read about the contribution process http://clojure.org/contributing but the summary process is to submit a patch against a Jira ticket for the repo. You can find links for all the individual Jira projects here: http://dev.clojure.org/display/design/Where+Did+Clojure.Contrib+Go That said, it's perfectly reasonable for pull requests to be discussed via Github before they transition into tickets in Jira with patches from folks who've signed and submitted a Contributor's Agreement, so I'll leave this open for Konrad to respond about the contents of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I should note that I haven't been following changes since forking. I do remember testing, but the test that I wrote consists of a copy of the sequence-m test modified to use m-lift-fn instead of m-lift. Please run tests before accepting, in case my memory is wrong.