CLJS-3233: :refer-global + :only, :require-global
#263
+228
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- basic impl test
- incorporate, untested
- :refer-global :only semantically more aligned w/ Clojure
- copy over logic from ns*
- add unit test
Support :require syntax for libraries external to the build - add external-dep? helper for new :external? property for :foreign libs - Need to implicitly create :external? :foreign libs from :require-global specs - elide these libs from the js inputs, they have no files - these libs don't need `goog.require` - add basic unit tests
- ns* case - require-global macro - require-global macro REPL support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-parse-global-refer, can only:renameif in:only