Support MongoDB 7.0 and 8.0 in $currentOp pipeline#19
Open
vtomasr5 wants to merge 1 commit into
Open
Conversation
Detect the server version on connect and gate truncateOps (added in 7.1) so the tool keeps working against 7.0 servers, which reject unknown $currentOp fields. Extend the projection with MongoDB 8.0 fields (queryFramework, cursor, progress, msg, numYields, appName, host, connectionId, write/prepare conflicts, throughput, twoPhaseCommitCoordinator, shard) and surface them in the operation details screen when present.
| self.server_version: tuple[int, int] = (0, 0) | ||
|
|
||
| @staticmethod | ||
| def _parse_server_version(version: str) -> tuple[int, int]: |
Comment on lines
+174
to
+178
| if write_conflicts: | ||
| details.append(f"Write Conflicts: {write_conflicts}") | ||
|
|
||
| prepare_read_conflicts = op.get("prepareReadConflicts") | ||
| if prepare_read_conflicts: |
Comment on lines
+246
to
+251
| if locks: | ||
| details.append("\nLocks:") | ||
| for key, value in locks.items(): | ||
| details.append(f" {key}: {value}") | ||
| if op.get("waitingForLock"): | ||
| details.append(" waitingForLock: True") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
serverStatus.versioninto(major, minor); gatetruncateOps(added in MongoDB 7.1) so the tool keeps working against 7.0, which rejects unknown$currentOpfields.$projectstage with MongoDB 8.0 fields:queryFramework,cursor,progress,msg,numYields,appName,host,connectionId,prepareReadConflicts,writeConflicts,dataThroughputLastSecond,dataThroughputAverage,twoPhaseCommitCoordinator,shard. Projecting a field that doesn't exist on a 7.0 doc is a no-op, so the projection itself is back-compat.OperationDetailsScreenwhen present (status msg, progress %, cursor block, transaction params incl.readConcern.level, 2PC coordinator, throughput, shard, app name, host+conn id, numYields, queryFramework).Test plan
uv run pytest -v— 119 passeduv run ruff check src/ tests/uv run ruff format --check src/ tests/truncateOps, plus a version-string parser test and an end-to-end connect-parses-version test