-
Notifications
You must be signed in to change notification settings - Fork 47
Split shovel into muliple files #1591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| module LavinMQ | ||
| module Shovel | ||
| abstract class Source | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this just be an empty abstract class?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the idea is that the Shovel::Runner takes a Source and a Destination the destination has abstract methods and it works since we already have three destinations implemented.
For Source we only have one implementation so we dont know what might be a good interface, but we can still use the abstract class in the runner and rely on duck typing.
|
There's some lint errors ( |
I want this PR to just be a split of files. Addressing the |
WHAT is this pull request doing?
Separate each component of the shovel feature into separate files. No functionality changes just moved the code into files to make it easier to browse it.