Skip to content

Conversation

@snichme
Copy link
Member

@snichme snichme commented Jan 8, 2026

WHAT is this pull request doing?

Separate each component of the shovel feature into separate files. No functionality changes just moved the code into files to make it easier to browse it.

@snichme snichme marked this pull request as ready for review January 12, 2026 12:33
@snichme snichme requested a review from a team as a code owner January 12, 2026 12:33
Comment on lines +1 to +6
module LavinMQ
module Shovel
abstract class Source
end
end
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this just be an empty abstract class?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the idea is that the Shovel::Runner takes a Source and a Destination the destination has abstract methods and it works since we already have three destinations implemented.

For Source we only have one implementation so we dont know what might be a good interface, but we can still use the abstract class in the runner and rely on duck typing.

@viktorerlingsson
Copy link
Member

viktorerlingsson commented Jan 13, 2026

There's some lint errors (not_nil! usage) that already existed prior to this refactor, but maybe they should be addressed?

@snichme
Copy link
Member Author

snichme commented Jan 13, 2026

There's some lint errors (not_nil! usage) that already existed prior to this refactor, but maybe they should be addressed?

I want this PR to just be a split of files. Addressing the not_nil! should be done but at some other change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants