Make release manifest shortNames legal install slugs - #397
Conversation
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
| * bindings (underscores, router maps _ -> -) where a hyphen does round-trip. | ||
| */ | ||
| export function releaseShortName(pkgName: string): string { | ||
| return gatekeeperShortName(pkgName).replace(/[^a-z0-9]/g, ""); |
There was a problem hiding this comment.
[P2] Guard against normalized short-name collisions
This transformation is lossy: for example, gatekeeper-foo-bar and gatekeeper-foobar both emit foobar. The deploy service then gives both installs the same GATEKEEPER_FOOBAR binding and the router can expose only one at /gatekeeper/foobar. The new manifest test checks validity per entry but not uniqueness, so such a release would pass. Please reject duplicate emitted shortNames (or use an explicit exceptional mapping) when assembling the manifest.
|
Posted 1 actionable inline finding. |
Preview:
|
The deploy wizard sends a gatekeeper's manifest shortName as the install slug verbatim, and the deploy service turns that slug into a GATEKEEPER_<SLUG> binding name, so it rejects anything outside /^[a-z][a-z0-9]*$/. gatekeeper-mcp-portal was the only installable gatekeeper whose shortName carried a hyphen, so installing Mcp-Portal failed zod validation on the first line of install() — before the workflow was ever created, surfacing to users as a redacted "Something unexpected went wrong on our side." with no workflow logs. Fold the release manifest's shortName into the slug charset via a new releaseShortName(), leaving gatekeeperShortName() alone: staging and preview bind gatekeepers as GATEKEEPER_<PKG_NAME> and the router maps _ back to -, so a hyphen does round-trip there and folding globally would point their BASE_URL at a 404. Assert in the generator test that every emitted shortName is a legal slug. The client passes shortName through unfolded, so this is what turns the next hyphenated gatekeeper into a release-build failure instead of a runtime 500. mcp-portal's deployed path becomes /gatekeeper/mcpportal, which stays self-consistent end to end; it registers no external redirect URI. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
6a0a701 to
205cd03
Compare
|
@Maximo-Guk Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
1 similar comment
|
@Maximo-Guk Bonk workflow failed. Check the logs for details. View workflow run · To retry, trigger Bonk again. |
1 participant
WIP