Add gha to upload Pyodide javascript bundle to GCS #2288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
5 times, most recently
from
b9d9440
to
9699f70
Compare
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
7 times, most recently
from
b8fd99a
to
146638c
Compare
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
3 times, most recently
from
c509902
to
592059f
Compare
hoodmane
changed the title
hoodmane
changed the title
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
from
592059f
to
7f3d33d
Compare
Should I wait for this to be done before reviewing? |
|
Perhaps. We probably don't need to even merge this since this action is intended to go into pyodide-build-scripts eventually. |
hoodmane
added a commit
that referenced
this pull request
Jul 29, 2024
Split off from #2288. This doesn't actually use the rule for anything yet, and perhaps we'll want to move this logic into pyodide-build-scripts eventually. But this will enable us to make tests that test against the Pyodide startup code in the source tree.
hoodmane
added a commit
that referenced
this pull request
Jul 29, 2024
Split off from #2288. This doesn't actually use the rule for anything yet, and perhaps we'll want to move this logic into pyodide-build-scripts eventually. But this will enable us to make tests that test against the Pyodide startup code in the source tree.
hoodmane
added a commit
that referenced
this pull request
Jul 29, 2024
Split off from #2288. This doesn't actually use the rule for anything yet, and perhaps we'll want to move this logic into pyodide-build-scripts eventually. But this will enable us to make tests that test against the Pyodide startup code in the source tree.
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
from
7f3d33d
to
f9c5c0d
Compare
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
3 times, most recently
from
319f0a4
to
7c8d78a
Compare
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
from
7c8d78a
to
76c05b4
Compare
This adds a github action that makes a binary file out of the pyodide capnproto bundle and uploads it to GCS. TODO: 1. Use the uploaded file (see #2430) 2. Move the pyodide js code and this script to pyodide-build-scripts repo.
We want Pyodide to decide we're a browser. It checks a few extra things in 0.26.0 before being convinced of this.
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
from
97cafc0
to
213243c
Compare
hoodmane
force-pushed
the
hoodmane/pyodide-load-from-file
branch
from
213243c
to
b83afe8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a github action that makes a binary file out of the pyodide capnproto
bundle and uploads it to GCS.
TODO: