IMAGES-1258: Don't pollute global scope with generally named types #2539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamIdeas
approved these changes
Aug 16, 2024
ns476
force-pushed
the
prefix-images-binding-types
branch
from
d50fd5f
to
3138a98
Compare
|
Would be good to see this merged soon if possible 👀 cc @penalosa |
penalosa
approved these changes
Sep 30, 2024
|
@ns476 Apologies for the delay here, but it looks like this branch has some conflicts—would you be able to fix those, and then we can get this released? |
ns476
force-pushed
the
prefix-images-binding-types
branch
from
3138a98
to
d02ca55
Compare
penalosa
approved these changes
Oct 2, 2024
jasnell
approved these changes
Oct 2, 2024
jclee
pushed a commit
that referenced
this pull request
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2537