Fix type params #2754
Merged
Fix type params #2754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If they need to be in sync, then maybe we should create a separate |
jasnell
approved these changes
Sep 24, 2024
RamIdeas
approved these changes
Sep 25, 2024
This sounds like a good idea to prevent this happening again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2652
A regression introduced in fc7f91d meant that parameter names for some APIs were no longer being included in the generated types, since
param-names-ast.c++didn't import them. This PR updates the includes withinparam-names-ast.c++to matchrtti.c++.