-
Notifications
You must be signed in to change notification settings - Fork 811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved tsconfig.json files in examples directory #4398
Improved tsconfig.json files in examples directory #4398
Conversation
🦋 Changeset detectedLatest commit: bf8c1eb The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4398 +/- ##
==========================================
+ Coverage 75.28% 75.31% +0.03%
==========================================
Files 223 223
Lines 12357 12357
Branches 3198 3198
==========================================
+ Hits 9303 9307 +4
+ Misses 3054 3050 -4 |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9872181421/npm-package-wrangler-4398 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4398/npm-package-wrangler-4398 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9872181421/npm-package-wrangler-4398 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9872181421/npm-package-create-cloudflare-4398 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9872181421/npm-package-cloudflare-kv-asset-handler-4398 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9872181421/npm-package-miniflare-4398 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9872181421/npm-package-cloudflare-pages-shared-4398 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9872181421/npm-package-cloudflare-vitest-pool-workers-4398 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Unfortunately I don't think we can merge this yet, since the version of esbuild
we use doesn't support TypeScript 5. We can definitely get it in after #3962 though!
The current template (uses 5.0.4) and my workers already run using TypeScript 5. What's the issue with TS 5? |
3b9dad2
to
5364355
Compare
5364355
to
bf8c1eb
Compare
I added a changeset and ran the e2e tests locally. LGTM |
Congratulations @mattpocock, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/clyfuajkc27880cjygs29zdeh This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
What this PR solves / how to test:
Updates out-of-date configuration settings in some of the tsconfig.json in the examples. Also updates the initial tsconfig.init.json.
Based on information here:
https://www.totaltypescript.com/tsconfig-cheat-sheet
This is not complete - but a lot of what I've added can be added into other tsconfig.json files throughout the repo.
Author has addressed the following: