Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved tsconfig.json files in examples directory #4398

Merged

Conversation

mattpocock
Copy link
Contributor

What this PR solves / how to test:

Updates out-of-date configuration settings in some of the tsconfig.json in the examples. Also updates the initial tsconfig.init.json.

Based on information here:

https://www.totaltypescript.com/tsconfig-cheat-sheet

This is not complete - but a lot of what I've added can be added into other tsconfig.json files throughout the repo.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because: just a change to the examples directory
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because: Unsure if this is a user-facing change

@mattpocock mattpocock requested a review from a team as a code owner November 8, 2023 11:10
Copy link

changeset-bot bot commented Nov 8, 2023

🦋 Changeset detected

Latest commit: bf8c1eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (35be459) 75.28% compared to head (f79fa20) 75.31%.
Report is 270 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4398      +/-   ##
==========================================
+ Coverage   75.28%   75.31%   +0.03%     
==========================================
  Files         223      223              
  Lines       12357    12357              
  Branches     3198     3198              
==========================================
+ Hits         9303     9307       +4     
+ Misses       3054     3050       -4     

see 3 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 8, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9872181421/npm-package-wrangler-4398

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/4398/npm-package-wrangler-4398

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9872181421/npm-package-wrangler-4398 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9872181421/npm-package-create-cloudflare-4398 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9872181421/npm-package-cloudflare-kv-asset-handler-4398
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9872181421/npm-package-miniflare-4398
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9872181421/npm-package-cloudflare-pages-shared-4398
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9872181421/npm-package-cloudflare-vitest-pool-workers-4398

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240701.0
workerd 1.20240701.0 1.20240701.0
workerd --version 1.20240701.0 2024-07-01

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Unfortunately I don't think we can merge this yet, since the version of esbuild we use doesn't support TypeScript 5. We can definitely get it in after #3962 though!

@pmbanugo
Copy link

pmbanugo commented Nov 8, 2023

Thanks for the PR! Unfortunately I don't think we can merge this yet, since the version of esbuild we use doesn't support TypeScript 5. We can definitely get it in after #3962 though!

The current template (uses 5.0.4) and my workers already run using TypeScript 5. What's the issue with TS 5?

@mrbbot mrbbot added the blocked Blocked on other work label Feb 7, 2024
@penalosa penalosa force-pushed the matt/fixed-tsconfigs-in-examples branch 3 times, most recently from 3b9dad2 to 5364355 Compare July 4, 2024 16:54
@petebacondarwin petebacondarwin self-assigned this Jul 10, 2024
@petebacondarwin petebacondarwin force-pushed the matt/fixed-tsconfigs-in-examples branch from 5364355 to bf8c1eb Compare July 10, 2024 10:03
@petebacondarwin
Copy link
Contributor

I added a changeset and ran the e2e tests locally. LGTM

@petebacondarwin petebacondarwin merged commit 4b1e5bc into cloudflare:main Jul 10, 2024
18 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jul 10, 2024
Copy link

holopin-bot bot commented Jul 10, 2024

Congratulations @mattpocock, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/clyfuajkc27880cjygs29zdeh

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked on other work contribution [Holopin] Recognizes an open-source contribution, big or small
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants