Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update unenv dependency version #6782

Merged
merged 2 commits into from
Sep 20, 2024
Merged

chore: update unenv dependency version #6782

merged 2 commits into from
Sep 20, 2024

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Sep 20, 2024

What this PR solves / how to test

Fixes cloudflare/workerd#2720

By pulling in unjs/unenv#310

Fixes N/A (the issue is on the worked repo)

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: unenv update
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: dep update

@vicb vicb requested a review from a team as a code owner September 20, 2024 06:32
Copy link

changeset-bot bot commented Sep 20, 2024

🦋 Changeset detected

Latest commit: 2937599

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb added the e2e Run e2e tests on a PR label Sep 20, 2024
Copy link
Contributor

github-actions bot commented Sep 20, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10956609520/npm-package-wrangler-6782

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6782/npm-package-wrangler-6782

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10956609520/npm-package-wrangler-6782 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10956609520/npm-package-create-cloudflare-6782 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10956609520/npm-package-cloudflare-kv-asset-handler-6782
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10956609520/npm-package-miniflare-6782
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10956609520/npm-package-cloudflare-pages-shared-6782
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10956609520/npm-package-cloudflare-vitest-pool-workers-6782
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10956609520/npm-package-cloudflare-workers-editor-shared-6782
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10956609520/npm-package-cloudflare-workers-shared-6782

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240909.4
workerd 1.20240909.0 1.20240909.0
workerd --version 1.20240909.0 2024-09-09

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the code that was broken to this file fixtures/nodejs-hybrid-app/src/index.ts to provide it was fixed.

image

@vicb
Copy link
Contributor Author

vicb commented Sep 20, 2024

Can you add the code that was broken to this file fixtures/nodejs-hybrid-app/src/index.ts to provide it was fixed.

image

I'll do but - I don't think this test belongs here vs unenv but I get that it's ok until we have a better test story for unenv.

@edmundhung edmundhung merged commit 7655505 into main Sep 20, 2024
25 of 26 checks passed
@edmundhung edmundhung deleted the unenv branch September 20, 2024 10:46
@vicb
Copy link
Contributor Author

vicb commented Sep 20, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 Bug Report — Runtime APIs: Error: [unenv] crypto.X509Certificate is not implemented yet!
3 participants