Add CF Tutorials to CF org automation #1364
Conversation
beyhan
force-pushed
the
add-cloudfoundry-tutorials
branch
4 times, most recently
from
22c54e2 to
ee37a5d
Compare
|
We explicitly state in https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0036-multiple-github-orgs.md#working-groups-are-per-cff-github-org
Let's discuss our options during the TOC meeting tomorrow. |
stephanme
left a comment
stephanme
left a comment
There was a problem hiding this comment.
The org automation won't work because Doc WG now contains repos from different github orgs. This breaks the team generation as described in [rfc-0014-github-teams-and-access.md|https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0014-github-teams-and-access.md]. Teams are local to a github org and it is not possible to grant repo access using teams of other orgs.
I should implement a test to let the validation fail for such a setup (currently, the resulting peribolos file is broken). IIRC, it was not possible so far to validate the repo org because of some exceptions here and there.
We could try to weaken this rule and e.g. allow different github orgs per WG area (but all repos within an area must be in the same org). Requires some changes to the team rules, e.g. it is not possible anymore to have a wg-[WORKING-GROUP-NAME] team with all reviewers/approvers but we can have such teams only per github org (i.e. there are 2 wg-docs teams: on in cloudfoundry and one in cloudfoundry-tutorial.
I had to work around a similar problem for wg-leads. Here I require that WG leads for WGs in other github orgs onboard additionally in the cloudfoundry org so that I can add them to the wg-leads team. This should work out because WG lead anyway have to maintain the WG charter in the community project.
toc/working-groups/docs.md
Outdated
| - name: Arsalan Khan | ||
| github: asalan316 | ||
| repositories: | ||
| - cloudfoundry-tutorials/cf4devs |
There was a problem hiding this comment.
Currently you can't have repos from different managed github orgs in one WG. The github org is defined on WG level (default: cloudfoundry). Validation seems to have room for improvement.
orgs/orgs.yml
Outdated
| description: Cloud Foundry for Developers. In depth, hands on training | ||
| has_projects: false | ||
| has_wiki: false | ||
| korifi-ci: |
There was a problem hiding this comment.
I believe this is a typo. This repo doesn't exist. korifi does exist.
beyhan
force-pushed
the
add-cloudfoundry-tutorials
branch
4 times, most recently
from
9be7590 to
2b169cd
Compare
This prs is adding the `cloudfoundry-tutorials` GitHub org to the CF org automation. Additionally, the pr proposes people who should interest to contribute to the tutorials as reviewers.
This is removing the archived repositories because repos will be migrated to the cloudfoundry org and we won't move archived repos.
beyhan
force-pushed
the
add-cloudfoundry-tutorials
branch
from
705aa47 to
4299007
Compare
* tutorials korifi repository will be renamed to intro-to-korifi * default branch is set to main
This prs is adding the
cloudfoundry-tutorialsGitHub org to the CF org automation. Additionally, the pr proposes people who should interest to contribute to the tutorials as reviewers.