Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route controller separation #3836

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Dariquest
Copy link
Contributor

Is there a related GitHub Issue?

No

What is this change about?

Route controller is being implemented as a separate binary

Does this PR introduce a breaking change?

No

Acceptance Steps

make generate
make test-e2e

Tag your pair, your PM, and/or team

@Dariquest Dariquest marked this pull request as draft March 3, 2025 16:14
@danail-branekov
Copy link
Member

Hi @Dariquest
I realise this PR is still in progress, but could we have the route-controller directory (both the top-level one and the one in the helm chart) renamed to something that reflects the purpose of the component, rather than its implementation? For example gatewayapi-networker?

Does this PR differ from #3830? Could we have it closed in favour of this one?

@Dariquest
Copy link
Contributor Author

Hi @Dariquest I realise this PR is still in progress, but could we have the route-controller directory (both the top-level one and the one in the helm chart) renamed to something that reflects the purpose of the component, rather than its implementation? For example gatewayapi-networker?

Does this PR differ from #3830? Could we have it closed in favour of this one?

Hi @danail-branekov,
good point with the naming. I will close the PR #3830 in a couple of days, as soon as this one and the internal one is ready. Hope this one does not bother too much for a couple of days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants