Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Supernova): Fix all typescript migration leftovers for Silences #769

Open
8 tasks
Tracked by #762
barsukov opened this issue Feb 10, 2025 · 0 comments
Open
8 tasks
Tracked by #762

(Supernova): Fix all typescript migration leftovers for Silences #769

barsukov opened this issue Feb 10, 2025 · 0 comments
Assignees
Labels
supernova All tasks related to supernova

Comments

@barsukov
Copy link
Contributor

barsukov commented Feb 10, 2025

Fix all typescript migration leftovers for Silences

Sub-tasks
Please have a look on all silences/* folder and fix related files, this is aprx, files and count of errors:

  • 8 src/components/silences/CreateSilence.tsx:39
  • 6 src/components/silences/ExpireSilence.tsx:13
  • 4 src/components/silences/RecreateSilence.tsx:121
  • 1 src/components/silences/silenceHelpers.ts:46
  • 25 src/components/silences/SilenceScheduled.tsx:7
  • 6 src/components/silences/SilencesList.tsx:41
  • 4 src/components/StoreProvider.tsx:7
  • 1 src/helpers.ts:9

Additional Context
Sometimes you will need to fix few other staff, try to minimaze it, keep PRs small and easy to review.

@barsukov barsukov added the supernova All tasks related to supernova label Feb 10, 2025
@barsukov barsukov changed the title Slices (Supernova): Fix all typescript migration leftovers for Slices Feb 10, 2025
@barsukov barsukov changed the title (Supernova): Fix all typescript migration leftovers for Slices (Supernova): Fix all typescript migration leftovers for Silences Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
supernova All tasks related to supernova
Projects
None yet
Development

No branches or pull requests

2 participants