Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(supernova): fix all typescript migration leftovers for Regions and Alerts #780

Merged
merged 20 commits into from
Feb 21, 2025
Merged

refactor(supernova): fix all typescript migration leftovers for Regions and Alerts #780

merged 20 commits into from
Feb 21, 2025

Conversation

TilmanHaupt
Copy link
Contributor

Summary

Typed filter store and components, removing @ts-ignore and any from this part of the codebase. This is part of the post-Supernova migration effort to clean up TypeScript errors. More PRs will follow for other areas.

Changes Made

closes #765

Testing Instructions

  1. npm i
  2. npm run TASK

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

@TilmanHaupt TilmanHaupt requested a review from a team as a code owner February 16, 2025 18:22
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 90756c2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudoperators/juno-app-supernova Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@TilmanHaupt TilmanHaupt added supernova All tasks related to supernova refactor labels Feb 16, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 16, 2025 •
edited
Loading

PR Preview Action v1.6.0
Preview removed because the pull request was closed.
2025-02-21 09:59 UTC

barsukov
barsukov reviewed Feb 17, 2025
View reviewed changes
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few little staff but in a file itsleft of createAlertSlices we still have a lot of anys do you want to get reed of them later?

@TilmanHaupt TilmanHaupt requested a review from edda February 20, 2025 12:31
@TilmanHaupt TilmanHaupt requested a review from edda February 20, 2025 14:05
edda
edda previously approved these changes Feb 20, 2025
View reviewed changes
barsukov
barsukov reviewed Feb 20, 2025
View reviewed changes
Copy link
Contributor

@barsukov barsukov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job little comments left

@TilmanHaupt TilmanHaupt merged commit d595b9d into main Feb 21, 2025
15 checks passed
@TilmanHaupt TilmanHaupt deleted the til-ts-super-region branch February 21, 2025 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barsukov barsukov barsukov left review comments

@ArtieReus ArtieReus ArtieReus left review comments

@edda edda edda approved these changes

@taymoor89 taymoor89 taymoor89 approved these changes

Assignees
No one assigned
Labels
refactor supernova All tasks related to supernova
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(Supernova): Fix all typescript migration leftovers for Regions
5 participants
@TilmanHaupt @edda @barsukov @ArtieReus @taymoor89