Skip to content

Conversation

tomMoral
Copy link
Contributor

@tomMoral tomMoral commented Mar 21, 2025

Set the co_filename to <dynamic-code> when pickling the code object to make the payload independent of where the code was defined.

TODO:

  • add test
  • add changelog

Fix #538

Copy link

codecov bot commented Mar 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.23%. Comparing base (f90f78a) to head (553025c).

❗ There is a different number of reports uploaded between BASE (f90f78a) and HEAD (553025c). Click for more details.

HEAD has 9 uploads less than BASE
Flag BASE (f90f78a) HEAD (553025c)
20 11
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #560      +/-   ##
==========================================
- Coverage   96.34%   89.23%   -7.12%     
==========================================
  Files           3        3              
  Lines         575      576       +1     
  Branches      121      121              
==========================================
- Hits          554      514      -40     
- Misses         11       49      +38     
- Partials       10       13       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@ogrisel ogrisel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea on how to debug the random failure but I found a typo...

@tomMoral
Copy link
Contributor Author

The failure is deterministic and only happening on windows and on this branch (see #562 running from master and working).
Not sure how to debug either...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

cloudpickle is not stable in notebooks

3 participants