Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct recommended var.name for auth0/app #1108

Merged
merged 2 commits into from
Sep 9, 2024
Merged

fix: Correct recommended var.name for auth0/app #1108

merged 2 commits into from
Sep 9, 2024

Conversation

milldr
Copy link
Member

@milldr milldr commented Sep 9, 2024

what

  • Update recommended name of the auth0/app components to avoid conflicts with the auth0/tenant component

why

  • Both were using auth0 as name before. This results in both components using the same module.this.id, which they both use to write AWS SSM parameters. These were clobbering each other and breaking the provider authentication

references

  • client engagement

@milldr milldr requested review from a team as code owners September 9, 2024 19:22
@milldr milldr enabled auto-merge (squash) September 9, 2024 19:23
@milldr milldr merged commit 5582764 into main Sep 9, 2024
4 checks passed
@milldr milldr deleted the feat/auth0-ssm-conflicts branch September 9, 2024 20:37
@milldr milldr mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benbentwo Benbentwo Benbentwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@milldr @Benbentwo