Skip to content

Conversation

getSurreal
Copy link

what

  • Add credentialSpecs parameter

why

  • Support an AWS documented parameter.
  • Needed for gMSA service account used with Active Directory authentication

references

@getSurreal getSurreal requested review from a team as code owners June 4, 2025 14:58
@getSurreal getSurreal requested review from Gowiem and nitrocode June 4, 2025 14:58
@mergify mergify bot added the triage Needs triage label Jun 4, 2025
@getSurreal
Copy link
Author

Looks like make init and make readme functionality has been removed. Let me know what the alternative steps are.

Copy link
Member

@Gowiem Gowiem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mergify mergify bot removed the triage Needs triage label Jun 5, 2025
@Gowiem
Copy link
Member

Gowiem commented Jun 6, 2025

/terratest

@getSurreal
Copy link
Author

The terratest error doesn't appear to be related to the changes. Any suggestion?

Error: /go/pkg/mod/golang.org/x/[email protected]/http2/transport.go:19:2: package io/fs is not in GOROOT (/__t/go/1.15.15/x64/src/io/fs)

@getSurreal
Copy link
Author

/terratest

@durangogt
Copy link

Can this PR get merged? It would be helpful for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants