Skip to content
This repository was archived by the owner on Oct 31, 2025. It is now read-only.

Potential fix for code scanning alert no. 2: Potentially unsafe quoting #16

Closed
wants to merge 1 commit into from
Closed

Potential fix for code scanning alert no. 2: Potentially unsafe quoting #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions internal/rows/arrowbased/columnValues.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@
}

if !strings.HasPrefix(string(key), "\"") {
r = r + "\"" + string(key) + "\":"

Check failure on line 301 in internal/rows/arrowbased/columnValues.go

View check run for this annotation

GitHub Advanced Security / CodeQL

Potentially unsafe quoting 

If this [JSON value](1) contains a double quote, it could break out of the enclosing quotes.
} else {
r = r + string(key) + ":"
}
Expand Down Expand Up @@ -543,8 +543,7 @@

func marshal(val any) ([]byte, error) {
if t, ok := val.(time.Time); ok {
s := "\"" + t.String() + "\""
return []byte(s), nil
return json.Marshal(t.String())
}
vb, err := json.Marshal(val)
return vb, err
Expand Down
Loading