Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade upload-artifact to v4 #335

Merged
merged 4 commits into from
Feb 20, 2025
Merged

Conversation

YueyingLu
Copy link
Member

@YueyingLu YueyingLu commented Feb 14, 2025

Description

Upgrade upload-artifact to v4 because https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (7468aa5) to head (d860ec9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
+ Coverage   93.59%   95.45%   +1.85%     
==========================================
  Files          61       61              
  Lines        4312     4312              
  Branches      525      664     +139     
==========================================
+ Hits         4036     4116      +80     
+ Misses        276      196      -80     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YueyingLu YueyingLu changed the title Upgrade upload-artifact to v4 chore: Upgrade upload-artifact to v4 Feb 17, 2025
@YueyingLu
Copy link
Member Author

The Visual Regression action failed on

Downloading snapshots created in run 12951677516
no valid artifacts found to download

because the run 12951677516 failed in the recent rerun in upload artifact step https://github.com/cloudscape-design/board-components/actions/runs/12951677516 so the artifact does not exist.

But the upload should actually work, proof is that the screenshot was updated in previous run in this PR https://github.com/cloudscape-design/board-components/actions/runs/13332149965

@YueyingLu YueyingLu marked this pull request as ready for review February 19, 2025 11:57
@YueyingLu YueyingLu requested a review from a team as a code owner February 19, 2025 11:57
@YueyingLu YueyingLu requested review from avinashbot and removed request for a team February 19, 2025 11:57
@YueyingLu YueyingLu added this pull request to the merge queue Feb 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 19, 2025
@YueyingLu YueyingLu added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit c756676 Feb 20, 2025
39 of 40 checks passed
@YueyingLu YueyingLu deleted the upgrade-upload-artifactv4 branch February 20, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants