-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Upgrade upload-artifact to v4 #335
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
==========================================
+ Coverage 93.59% 95.45% +1.85%
==========================================
Files 61 61
Lines 4312 4312
Branches 525 664 +139
==========================================
+ Hits 4036 4116 +80
+ Misses 276 196 -80 ☔ View full report in Codecov by Sentry. |
d58e150
to
59ba324
Compare
The Visual Regression action failed on
because the run 12951677516 failed in the recent rerun in upload artifact step https://github.com/cloudscape-design/board-components/actions/runs/12951677516 so the artifact does not exist. But the upload should actually work, proof is that the screenshot was updated in previous run in this PR https://github.com/cloudscape-design/board-components/actions/runs/13332149965 |
Description
Upgrade upload-artifact to v4 because https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.