Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Adds combination of package versions that need no skipLibCheck #124

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

orangevolon
Copy link
Contributor

@orangevolon orangevolon commented Jan 21, 2025

Issue #, if available:

Description of changes:

This combination of package versions and the tsconfig.json doesn't need skipLibCheck: true.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@orangevolon orangevolon marked this pull request as ready for review January 22, 2025 08:38
@orangevolon orangevolon requested a review from a team as a code owner January 22, 2025 08:38
@orangevolon orangevolon requested review from johannes-weber and pan-kot and removed request for a team January 22, 2025 08:38
johannes-weber
johannes-weber previously approved these changes Jan 22, 2025
@pan-kot pan-kot force-pushed the chore-webdriverio9 branch from 3377919 to dfe1c1a Compare February 3, 2025 10:07
Base automatically changed from chore-webdriverio9 to main February 13, 2025 20:48
@pan-kot pan-kot dismissed johannes-weber’s stale review February 13, 2025 20:48

The base branch was changed.

@orangevolon orangevolon force-pushed the alamiami/fixing-the-dependency-mismatch branch from 9e1ef29 to 9819f74 Compare February 19, 2025 11:17
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.66%. Comparing base (f58bfa8) to head (f261089).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #124   +/-   ##
=======================================
  Coverage   91.66%   91.66%           
=======================================
  Files          18       18           
  Lines         396      396           
  Branches       63       63           
=======================================
  Hits          363      363           
  Misses         29       29           
  Partials        4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orangevolon orangevolon force-pushed the alamiami/fixing-the-dependency-mismatch branch from 9819f74 to 0205c15 Compare February 19, 2025 11:20
@orangevolon orangevolon added this pull request to the merge queue Feb 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 19, 2025
@orangevolon orangevolon force-pushed the alamiami/fixing-the-dependency-mismatch branch from 0205c15 to f261089 Compare February 20, 2025 09:06
@orangevolon orangevolon added this pull request to the merge queue Feb 20, 2025
@orangevolon
Copy link
Contributor Author

Build looks green on dev pipeline

@orangevolon orangevolon removed this pull request from the merge queue due to a manual request Feb 20, 2025
@orangevolon orangevolon added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit dc7cf82 Feb 20, 2025
37 checks passed
@orangevolon orangevolon deleted the alamiami/fixing-the-dependency-mismatch branch February 20, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants