Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deprecate ariaLabel in ChatBubble component #44

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johannes-weber
Copy link
Member

@johannes-weber johannes-weber commented Feb 20, 2025

Description

The role group was preventing the contents of the chat bubble message from being announced by aria-live when the message appeared. With that the aria-label property gets obsolete.

Follow up after merge:

Related links, issue #, if available: AWSUI-60402

How has this been tested?

  • verified manually
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.86%. Comparing base (8920006) to head (0c2153e).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #44      +/-   ##
==========================================
- Coverage   97.87%   97.86%   -0.02%     
==========================================
  Files          30       30              
  Lines         707      701       -6     
  Branches      110      110              
==========================================
- Hits          692      686       -6     
  Misses         12       12              
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The role group was preventing the contents of the chat bubble message from being announced by aria-live when the message appeared. With that the aria-label property gets obsolete.
@johannes-weber johannes-weber force-pushed the jowejowe/remove-role-group-and-deprecate-aria-label branch from e6555c7 to 0c2153e Compare February 21, 2025 05:23
@johannes-weber johannes-weber marked this pull request as ready for review February 21, 2025 05:38
@johannes-weber johannes-weber requested a review from a team as a code owner February 21, 2025 05:38
@johannes-weber johannes-weber requested review from pan-kot and removed request for a team February 21, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant