chore: Add puppeteer-core dependency #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
commented
Feb 20, 2025
| @@ -114,6 +114,7 @@ | |||
| "lodash-es": "^4.17.21", | |||
| "npm-run-all": "^4.1.5", | |||
| "prettier": "^3.3.3", | |||
| "puppeteer-core": "^22.15.0", | |||
There was a problem hiding this comment.
The latest is 24.x, I set it to 22.x to be in sync with what webdriverio wants: https://github.com/webdriverio/webdriverio/blob/main/packages/webdriverio/package.json#L105
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage 99.20% 99.20%
=======================================
Files 28 28
Lines 251 251
Branches 30 30
=======================================
Hits 249 249
Misses 1 1
Partials 1 1 ☔ View full report in Codecov by Sentry. |
just-boris
requested review from
johannes-weber
and removed request for
a team
johannes-weber
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixing this build issue: https://github.com/cloudscape-design/chat-components/actions/runs/13394949739/job/37411525211?pr=42
puppeteer-coreis an optional peer dependency of webdriverio, typically not needed, but in this use-case we depend on it for taking screenshots, so need to be installedRelated links, issue #, if available: n/a
How has this been tested?
PR build passes (aka fails with a different known error)
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.