fix: Make sure clearVisualRefreshState helper removes the class too #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
just-boris
requested review from
johannes-weber
and removed request for
a team
just-boris
commented
Feb 11, 2025
| @@ -18,8 +18,10 @@ describe('useVisualRefresh', () => { | |||
| return <div data-testid="current-mode">{isRefresh.toString()}</div>; | |||
| } | |||
|
|
|||
| beforeEach(() => clearVisualRefreshState()); | |||
| afterEach(() => document.body.classList.remove('awsui-visual-refresh')); | |||
There was a problem hiding this comment.
Why was this not captured before – we cleaned it up in the unit tests manually
When I tried to use this utility in cloudscape-design/components, I found that it does not reset to classic properly
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 99.30% 99.30%
=======================================
Files 29 29
Lines 715 717 +2
Branches 194 187 -7
=======================================
+ Hits 710 712 +2
Misses 5 5 ☔ View full report in Codecov by Sentry. |
just-boris
changed the title
johannes-weber
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This utility should live the pristine state
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.