Skip to content

Commit

Permalink
test: Re-enabled mixed chart hover test (#3306)
Browse files Browse the repository at this point in the history
  • Loading branch information
pan-kot authored Feb 21, 2025
1 parent 63e53ad commit 22d7bca
Showing 1 changed file with 11 additions and 6 deletions.
17 changes: 11 additions & 6 deletions src/mixed-line-bar-chart/__integ__/mixed-line-bar-chart.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -504,26 +504,31 @@ describe('Details popover', () => {
await page.windowScrollTo({ top: 150 });
const barChart = createWrapper().findBarChart();
const barGroup = barChart.findBarGroups().get(1).toSelector();
await expect(page.getWindowScroll()).resolves.toEqual({ top: 150, left: 0 });
await expect(page.getWindowScroll().then(s => s.top)).resolves.toBe(150);
await page.clickBarGroup(barGroup);
await page.waitForVisible(barChart.findDetailPopover().toSelector());
await expect(page.getText(barChart.findDetailPopover().findHeader().toSelector())).resolves.toContain('Apr 2023');
await expect(page.getWindowScroll()).resolves.toEqual({ top: 0, left: 0 });
await expect(page.getWindowScroll().then(s => s.top)).resolves.toBe(0);
})
);

// Skipped due to failures with WebdriverIO v9.
test.skip(
test(
'does not scroll on hover',
setupTest('#/light/bar-chart/drilldown', async page => {
await page.setWindowSize({ width: 360, height: 650 });
await page.windowScrollTo({ top: 150 });
const barChart = createWrapper().findBarChart();
const barGroup = barChart.findBarGroups().get(1).toSelector();
await expect(page.getWindowScroll()).resolves.toEqual({ top: 150, left: 0 });
await expect(page.getWindowScroll().then(s => s.top)).resolves.toBe(150);
await page.hoverElement(barGroup);
await page.waitForVisible(barChart.findDetailPopover().toSelector());
await expect(page.getText(barChart.findDetailPopover().findHeader().toSelector())).resolves.toContain('Apr 2023');
await expect(page.getWindowScroll()).resolves.toEqual({ top: 150, left: 0 });

// Explanation: when a series is hovered we expect no extra scroll, so the page's scroll should stay at 150px.
// However, Webdriver automatically performs scroll adjustments when hovering to make the element fit the screen,
// so we give it a small extra allowance.
await expect(page.getWindowScroll().then(s => s.top)).resolves.toBeGreaterThanOrEqual(150);
await expect(page.getWindowScroll().then(s => s.top)).resolves.toBeLessThan(250);
})
);

Expand Down

0 comments on commit 22d7bca

Please sign in to comment.