fix: Prevent filtering highlighting from crashing when match is >1000…

…0 chars (#3290)
cloudscape-design · Feb 12, 2025 · 2966baa · 2966baa
1 parent 9976a86
commit 2966baa
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/internal/components/option/__tests__/option.test.tsx b/src/internal/components/option/__tests__/option.test.tsx
@@ -305,10 +305,10 @@ describe('Option component', () => {
     test('skips highlighting if the label text is too long', () => {
       const optionWrapper = renderOption({
         option: {
-          label: 'a'.repeat(1000000),
+          label: 'a'.repeat(100000),
           value: '1',
         },
-        highlightText: 'a'.repeat(500000),
+        highlightText: 'a'.repeat(50000),
       });
       checkMatches(optionWrapper, 0, '');
     });

diff --git a/src/internal/components/option/highlight-match.tsx b/src/internal/components/option/highlight-match.tsx
@@ -7,7 +7,7 @@ import styles from './styles.css.js';
 const splitOnFiltering = (str: string, highlightText: string) => {
   // We match by creating a regex using user-provided strings, so we skip
   // highlighting if the generated regex would be too memory intensive.
-  if (highlightText.length > 100000) {
+  if (highlightText.length > 10_000) {
     return { noMatches: [str], matches: null };
   }