-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fix test-utils wrappers inheritance #3287
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3287 +/- ##
=======================================
Coverage 96.41% 96.41%
=======================================
Files 791 791
Lines 22563 22563
Branches 7726 7786 +60
=======================================
Hits 21755 21755
- Misses 754 801 +47
+ Partials 54 7 -47 ☔ View full report in Codecov by Sentry. |
f83cfce
to
0157dbb
Compare
const nextInput = wrapper.findRow(1)!.findAutosuggest()!.findNativeInput().getElement(); | ||
const nextInput = wrapper | ||
.findRow(1)! | ||
.findField(1)! | ||
.findControl()! | ||
.findAutosuggest()! | ||
.findNativeInput() | ||
.getElement(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bonus effect of this improvement. Now we strictly target the first column in a row and not an autosuggest in any column
0157dbb
to
dc69ef8
Compare
dc69ef8
to
8dd76c1
Compare
Description
Fix this use-case
Three cases will remain unfixed after this change
DropdownWrapper – there is too much code assuming it is an element wrapper, it requires a fix on its own
components/src/test-utils/dom/internal/dropdown.ts
Line 6 in 9976a86
TooltipWrapper - this class is empty, unclear why it exists at all
components/src/test-utils/dom/internal/tooltip.ts
Line 7 in 9976a86
OptionsList – same, also empty
components/src/test-utils/dom/internal/options-list.ts
Line 7 in 9976a86
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md
.CONTRIBUTING.md
.Security
checkSafeUrl
function.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.