Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Breadcrumb dropdown items have same color on mouse or keyboard interaction #3288

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

johannes-weber
Copy link
Member

@johannes-weber johannes-weber commented Feb 12, 2025

Description

Before this change, Breadcrumb group's dropdown items had different colors when navigating via keyboard or via mouse.
Screenshot 2025-02-12 at 15 39 13

With this change, the dropdown items do have the same color on mouse and kyboard interaction.

Related links, issue #, if available: AWSUI-60237

How has this been tested?

  • Tested manually.
  • How to test: open the breadcrumb group test page, open the dropdown with either keyboard or mouse, navigate in between the items and observe the selected items text color.
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (0938d47) to head (2db8fa3).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3288    +/-   ##
========================================
  Coverage   96.42%   96.42%            
========================================
  Files         791      791            
  Lines       22574    22575     +1     
  Branches     7388     7805   +417     
========================================
+ Hits        21766    21767     +1     
+ Misses        801      754    -47     
- Partials        7       54    +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannes-weber johannes-weber marked this pull request as ready for review February 12, 2025 14:45
@johannes-weber johannes-weber requested a review from a team as a code owner February 12, 2025 14:45
@johannes-weber johannes-weber requested review from YueyingLu and removed request for a team February 12, 2025 14:45
@johannes-weber johannes-weber added this pull request to the merge queue Feb 13, 2025
Merged via the queue into main with commit e389b28 Feb 13, 2025
41 checks passed
@johannes-weber johannes-weber deleted the jowejowe/fix-breadcrumb-dropdown-link-color branch February 13, 2025 09:19
georgylobko pushed a commit that referenced this pull request Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants