-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Parent container scrolls when select opens #3292
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b90f1f8
to
a599a48
Compare
a599a48
to
357f73f
Compare
357f73f
to
0982afe
Compare
0982afe
to
02c1d55
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3292 +/- ##
=======================================
Coverage 96.41% 96.41%
=======================================
Files 791 791
Lines 22564 22564
Branches 7727 7789 +62
=======================================
Hits 21756 21756
Misses 754 754
Partials 54 54 ☔ View full report in Codecov by Sentry. |
cf4d483
to
4f75634
Compare
Al-Dani
approved these changes
Feb 14, 2025
georgylobko
pushed a commit
that referenced
this pull request
Feb 18, 2025
Co-authored-by: Yueying Lu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix issue AWSUI-60318
Issue:
When Select locates top inside of a
overflow:hidden
container and at the bottom of the window, the select can not open upwards becauseoverflow:hidden
and has little space downwards to display the dropdown. When open the dropdown with a selected option, the page scrolls up. See screen recording in the ticket.Cause:
Fix:
Test:
Tested manually and added integ tests in the PR.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.