Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add setSelectionRange to PromptInput #3294

Merged
merged 3 commits into from
Feb 14, 2025

Conversation

gethinwebster
Copy link
Member

@gethinwebster gethinwebster commented Feb 13, 2025

Description

Add setSelectionRange to PromptInput

Related links, issue #, if available: AWSUI-60374

How has this been tested?

New unit test

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.41%. Comparing base (e389b28) to head (b650771).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3294    +/-   ##
========================================
  Coverage   96.41%   96.41%            
========================================
  Files         791      791            
  Lines       22564    22566     +2     
  Branches     7727     7381   -346     
========================================
+ Hits        21756    21758     +2     
- Misses        754      801    +47     
+ Partials       54        7    -47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gethinwebster gethinwebster marked this pull request as ready for review February 13, 2025 09:58
@gethinwebster gethinwebster requested a review from a team as a code owner February 13, 2025 09:58
@gethinwebster gethinwebster requested review from connorlanigan and removed request for a team February 13, 2025 09:58
pan-kot
pan-kot previously approved these changes Feb 13, 2025
@gethinwebster gethinwebster added this pull request to the merge queue Feb 14, 2025
Merged via the queue into main with commit fca5d5f Feb 14, 2025
38 checks passed
@gethinwebster gethinwebster deleted the prompt-input-selection-range branch February 14, 2025 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants