Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: Adds group role and aria label to flash focus (#3263) #3302

Merged

Conversation

orangevolon
Copy link
Contributor

This reverts commit c6ed14c.

Description

Related links, issue #, if available: n/a

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@orangevolon orangevolon requested a review from a team as a code owner February 19, 2025 11:41
@orangevolon orangevolon requested review from just-boris and removed request for a team February 19, 2025 11:41
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (d6733f7) to head (5509dfe).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3302      +/-   ##
==========================================
- Coverage   96.42%   96.42%   -0.01%     
==========================================
  Files         791      791              
  Lines       22605    22603       -2     
  Branches     7814     7806       -8     
==========================================
- Hits        21797    21795       -2     
  Misses        754      754              
  Partials       54       54              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@just-boris just-boris added this pull request to the merge queue Feb 19, 2025
Merged via the queue into main with commit 20e6a83 Feb 19, 2025
38 checks passed
@just-boris just-boris deleted the alamiami/reverts-add-group-role-and-aria-label-to-flash-focus branch February 19, 2025 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants