Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade list of supported browsers #3304

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

jperals
Copy link
Member

@jperals jperals commented Feb 20, 2025

Description

Now that Safari 18 is out, we officially support only Safari 16+, but our current version of caniuse is still enforcing Safari 15 compatibility due to not being aware of Safari 18.

In particular, it is not allowing to use the :has() pseudo-selector which I need to use here. (But updating the browsers list is good in itself anyway)

Upgraded caniuse by running npx update-browserslist-db.

Also had to upgrade stylelint-no-unsupported-browser-features due to this issue.

Related links, issue #, if available: n/a

How has this been tested?

Only after these changes I was able to commit #3303 without stylelint errors. (But decided to ship this in a separate PR first)

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (20e6a83) to head (710e5f9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #3304    +/-   ##
========================================
  Coverage   96.42%   96.42%            
========================================
  Files         791      791            
  Lines       22603    22603            
  Branches     7396     7805   +409     
========================================
  Hits        21795    21795            
  Misses        801      801            
  Partials        7        7            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jperals jperals marked this pull request as ready for review February 20, 2025 09:24
@jperals jperals requested a review from a team as a code owner February 20, 2025 09:24
@jperals jperals requested review from YueyingLu and removed request for a team February 20, 2025 09:24
@jperals jperals added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 125ab47 Feb 21, 2025
41 checks passed
@jperals jperals deleted the chore/upgrade-browserslist branch February 21, 2025 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants