Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add arrow-up and arrow-down icons #3305

Merged
merged 2 commits into from
Feb 21, 2025
Merged

feat: Add arrow-up and arrow-down icons #3305

merged 2 commits into from
Feb 21, 2025

Conversation

avinashbot
Copy link
Member

@avinashbot avinashbot commented Feb 20, 2025

Description

Adding arrow-up and arrow-down (we already have arrow-left and arrow-right) to support the upcoming drag and drop implementation. Co-authored with Atsushi because he helped me figure out how to get the icon SVG :)

Related links, issue #, if available: n/a

How has this been tested?

Should show up in permutation tests.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.42%. Comparing base (20e6a83) to head (247b727).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3305   +/-   ##
=======================================
  Coverage   96.42%   96.42%           
=======================================
  Files         791      791           
  Lines       22603    22603           
  Branches     7396     7396           
=======================================
  Hits        21795    21795           
  Misses        801      801           
  Partials        7        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@avinashbot avinashbot marked this pull request as ready for review February 21, 2025 10:24
@avinashbot avinashbot requested a review from a team as a code owner February 21, 2025 10:24
@avinashbot avinashbot requested review from abdhalees and removed request for a team February 21, 2025 10:24
@avinashbot avinashbot added this pull request to the merge queue Feb 21, 2025
Merged via the queue into main with commit 6ef8141 Feb 21, 2025
39 checks passed
@avinashbot avinashbot deleted the arrow-up-down branch February 21, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants