Skip to content

Comments

chore: Emit funnelStepError instead of funnelError where possible#3393

Merged
connorlanigan merged 6 commits intomainfrom
feat/funnel-substep-error
Apr 2, 2025
Merged

chore: Emit funnelStepError instead of funnelError where possible#3393
connorlanigan merged 6 commits intomainfrom
feat/funnel-substep-error

Conversation

@connorlanigan
Copy link
Member

@connorlanigan connorlanigan commented Mar 31, 2025

Description

Where possible, we now emit the funnelStepError event instead of funnelError. The funnelStepError event has more information about the context in which the event happened.

This applies to three components:

  • Alert (when it is placed inside a step)
  • Form (which itself makes up a single step)
  • Wizard

Related links, issue #, if available:

  • AWSUI-60507

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@connorlanigan connorlanigan requested a review from a team as a code owner March 31, 2025 14:15
@connorlanigan connorlanigan requested review from gethinwebster and removed request for a team March 31, 2025 14:15
gethinwebster
gethinwebster previously approved these changes Mar 31, 2025
@codecov
Copy link

codecov bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 96.96970% with 1 line in your changes missing coverage. Please review.

Project coverage is 96.46%. Comparing base (afdd066) to head (32b1172).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
src/form/index.tsx 91.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3393      +/-   ##
==========================================
- Coverage   96.47%   96.46%   -0.01%     
==========================================
  Files         805      805              
  Lines       22975    22997      +22     
  Branches     7936     7944       +8     
==========================================
+ Hits        22164    22183      +19     
+ Misses        804      760      -44     
- Partials        7       54      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gethinwebster
gethinwebster previously approved these changes Apr 1, 2025
@connorlanigan connorlanigan added this pull request to the merge queue Apr 2, 2025
Merged via the queue into main with commit cf89146 Apr 2, 2025
38 checks passed
@connorlanigan connorlanigan deleted the feat/funnel-substep-error branch April 2, 2025 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants