Skip to content

Conversation

@jperals
Copy link
Member

@jperals jperals commented Nov 18, 2025

Description

Small follow-up from #4021.

Move style utilities that are specific to the (internal) radio button component also into the radio button directory, to keep dependencies unidirectional: radio group depends on radio button and not the other way around.

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jperals jperals changed the title Move style utils to internal radio button component chore: Move style utils to internal radio button component Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.12%. Comparing base (c02fc0d) to head (93a3546).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4049   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files         864      864           
  Lines       25325    25325           
  Branches     9137     9138    +1     
=======================================
  Hits        24597    24597           
+ Misses        722      681   -41     
- Partials        6       47   +41     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jperals jperals marked this pull request as ready for review November 18, 2025 22:18
@jperals jperals requested a review from a team as a code owner November 18, 2025 22:18
@jperals jperals requested review from ernst-dev and removed request for a team November 18, 2025 22:18
@jperals jperals enabled auto-merge November 18, 2025 22:23
@jperals jperals added this pull request to the merge queue Dec 3, 2025
Merged via the queue into main with commit 5a7ae01 Dec 3, 2025
49 checks passed
@jperals jperals deleted the chore/refactor-radio-button-styles branch December 3, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants