refactor: Apply padding to option-content-div instead of selectable-item outer-div #4070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpyZzey
temporarily deployed
to
dev-pages-react18
GitHub Actions
Inactive
SpyZzey
temporarily deployed
to
dev-pages-react16
GitHub Actions
Inactive
SpyZzey
force-pushed
the
refactor/apply-padding-to-option-content
branch
from
a371e6c to
d2d1275
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4070 +/- ##
=======================================
Coverage 97.12% 97.12%
=======================================
Files 864 864
Lines 25325 25330 +5
Branches 9137 9140 +3
=======================================
+ Hits 24597 24602 +5
+ Misses 722 681 -41
- Partials 6 47 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
SpyZzey
force-pushed
the
refactor/apply-padding-to-option-content
branch
from
c42d2ea to
47d35a0
Compare
jperals
reviewed
Dec 4, 2025
jperals
reviewed
Dec 4, 2025
pages/selectable-item/common.tsx
Outdated
| highlighted: [false, true], | ||
| disabled: [false, true], | ||
| children: [simpleOption], | ||
| disableContentStyling: [true], |
Member
There was a problem hiding this comment.
Shouldn't disableContentStyling be [false] (for each item)?
jperals
reviewed
Dec 4, 2025
| export default function InputPermutations() { | ||
| return ( | ||
| <> | ||
| <h1>Selectable item permutations</h1> |
Member
There was a problem hiding this comment.
Minor: suggest to change the title to reflect the difference between this page and the one that it was copied from.
| <> | ||
| <h1>Selectable item permutations</h1> | ||
| <ScreenshotArea> | ||
| <SpaceBetween size="xs"> |
Member
There was a problem hiding this comment.
I don't think this SpaceBetween does anything, since it conatins one single element.
| } | ||
| &.highlighted { | ||
| color: awsui.$color-text-dropdown-item-highlighted; | ||
| > .selectable-item-content { |
Member
There was a problem hiding this comment.
Nitpick: these two nested rulesets could be merged into one
&.highlighted > .selectable-item-content { ... }
jperals
approved these changes
Dec 4, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
at-susie
pushed a commit
that referenced
this pull request
Dec 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, the hierarchical padding is applied to the same div as the border and the padding (border-width padding) when selected/unselected. This PR moves this "business"-padding (e.g. hierarchical padding, general spacing padding) to the inner option-content div, which was previously only used for testing.
This is needed so we can extend the selectable-item components to allow for custom styling in the content by removing this "business"-padding.
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.