Skip to content

Conversation

@Harsh-Anand-Singh
Copy link
Member

@Harsh-Anand-Singh Harsh-Anand-Singh commented Dec 1, 2025

Description

This PR adds a default aria-label for the DatePicker calendar button, fixing an accessibility issue where the button had no label when openCalendarAriaLabel was not provided.

Related links, issue #, if available: AWSUI-61446

How has this been tested?

Added unit tests to verify the calendar button has the correct default aria-label with and without a selected date.

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@Harsh-Anand-Singh Harsh-Anand-Singh changed the title feat: add internationalization support for openCalendarAriaLabel acce… feat: add internationalization support for openCalendarAriaLabel Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.12%. Comparing base (c02fc0d) to head (44b0751).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4082   +/-   ##
=======================================
  Coverage   97.12%   97.12%           
=======================================
  Files         864      864           
  Lines       25325    25328    +3     
  Branches     9137     9138    +1     
=======================================
+ Hits        24597    24600    +3     
  Misses        722      722           
  Partials        6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Harsh-Anand-Singh Harsh-Anand-Singh force-pushed the openCalendarAriaLabel-i18n-addition branch from 007cd9e to 847c713 Compare December 3, 2025 11:22
@Harsh-Anand-Singh Harsh-Anand-Singh added this pull request to the merge queue Dec 4, 2025
Merged via the queue into main with commit 41da37c Dec 4, 2025
49 checks passed
@Harsh-Anand-Singh Harsh-Anand-Singh deleted the openCalendarAriaLabel-i18n-addition branch December 4, 2025 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants