chore: Adds set native value dom util #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #81 +/- ##
=======================================
Coverage 95.92% 95.92%
=======================================
Files 9 9
Lines 319 319
Branches 68 68
=======================================
Hits 306 306
Misses 13 13 ☔ View full report in Codecov by Sentry. |
src/core/utils-dom.ts
Outdated
| @@ -7,3 +7,23 @@ import * as React from 'react'; | |||
| import { act as reactDomAct } from 'react-dom/test-utils'; | |||
|
|
|||
| export const act = ('act' in React ? React.act : reactDomAct) as typeof reactDomAct; | |||
|
|
|||
| // Copied from @testing-library/dom/dist/events.js | |||
There was a problem hiding this comment.
I'm not sure this is sufficient attribution for the usage. We might need to include the license type as well as a link to the original source code.
Or maybe something similar to what we have here: https://github.com/cloudscape-design/components/blob/main/THIRD-PARTY-LICENSES
There was a problem hiding this comment.
Do we have any other examples in the components repo of usages of just a single function being copied in?
pan-kot
force-pushed
the
chore-set-native-value-util
branch
from
4b23257 to
5e569ef
Compare
avinashbot
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for: cloudscape-design/components#3252
Rel: AWSUI-60345
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.